linux-kernel - RE: [PATCH 2/4] drivers/staging/mei/interface.c: take size of pointed value, not pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6F5C1D715B2DA5498A628E6B9C124F0401C7CA462E@hasmsx504.ger.corp.intel.com>
Date:	Sat, 17 Sep 2011 20:53:10 +0300
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Julia Lawall <julia@...u.dk>, Greg Kroah-Hartman <gregkh@...e.de>
CC:	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
	"Weil, Oren jer" <oren.jer.weil@...el.com>,
	"Tzeel-Krupp, Itzhak" <itzhak.tzeel-krupp@...el.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/4] drivers/staging/mei/interface.c: take size of
 pointed value, not pointer



> -----Original Message-----
> From: Julia Lawall [mailto:julia@...u.dk]
> Sent: Friday, September 16, 2011 9:58 AM
> To: Greg Kroah-Hartman
> Cc: kernel-janitors@...r.kernel.org; Winkler, Tomas; Weil, Oren jer; Tzeel-
> Krupp, Itzhak; devel@...verdev.osuosl.org; linux-kernel@...r.kernel.org
> Subject: [PATCH 2/4] drivers/staging/mei/interface.c: take size of pointed
> value, not pointer
> 
> From: Julia Lawall <julia@...u.dk>
> 
> Sizeof a pointer-typed expression returns the size of the pointer, not that of
> the pointed data.
> 
> The semantic patch that fixes this problem is as follows:
> (http://coccinelle.lip6.fr/)
> 
> // <smpl>
> @@
> expression *e;
> type T;
> identifier f;
> @@
> 
> f(...,(T)e,...,
> -sizeof(e)
> +sizeof(*e)
> ,...)
> // </smpl>
> 
> Signed-off-by: Julia Lawall <julia@...u.dk>
Acked-by: Tomas Winkler <tomas.winkler@...el.com>

> 
> ---
>  drivers/staging/mei/interface.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff -u -p a/drivers/staging/mei/interface.c b/drivers/staging/mei/interface.c
> --- a/drivers/staging/mei/interface.c
> +++ b/drivers/staging/mei/interface.c
> @@ -332,7 +332,7 @@ int mei_send_flow_control(struct mei_dev
>  	mei_hdr->reserved = 0;
> 
>  	mei_flow_control = (struct hbm_flow_control *) &dev-
> >wr_msg_buf[1];
> -	memset(mei_flow_control, 0, sizeof(mei_flow_control));
> +	memset(mei_flow_control, 0, sizeof(*mei_flow_control));
>  	mei_flow_control->host_addr = cl->host_client_id;
>  	mei_flow_control->me_addr = cl->me_client_id;
>  	mei_flow_control->cmd.cmd = MEI_FLOW_CONTROL_CMD; @@ -
> 396,7 +396,7 @@ int mei_disconnect(struct mei_device *de
> 
>  	mei_cli_disconnect =
>  	    (struct hbm_client_disconnect_request *) &dev->wr_msg_buf[1];
> -	memset(mei_cli_disconnect, 0, sizeof(mei_cli_disconnect));
> +	memset(mei_cli_disconnect, 0, sizeof(*mei_cli_disconnect));
>  	mei_cli_disconnect->host_addr = cl->host_client_id;
>  	mei_cli_disconnect->me_addr = cl->me_client_id;
>  	mei_cli_disconnect->cmd.cmd = CLIENT_DISCONNECT_REQ_CMD;

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/