linux-kernel - Re: [PATCH v2 1/7] Basic kernel memory functionality for the Memory Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110918204335.GB28611@shutemov.name>
Date:	Sun, 18 Sep 2011 23:43:35 +0300
From:	"Kirill A. Shutemov" <kirill@...temov.name>
To:	Glauber Costa <glommer@...allels.com>
Cc:	linux-kernel@...r.kernel.org, paul@...lmenage.org,
	lizf@...fujitsu.com, kamezawa.hiroyu@...fujitsu.com,
	ebiederm@...ssion.com, davem@...emloft.net, gthelen@...gle.com,
	netdev@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [PATCH v2 1/7] Basic kernel memory functionality for the Memory
 Controller

On Sun, Sep 18, 2011 at 05:40:11PM -0300, Glauber Costa wrote:
> On 09/18/2011 05:39 PM, Kirill A. Shutemov wrote:
> > On Sun, Sep 18, 2011 at 04:11:21PM -0300, Glauber Costa wrote:
> >> On 09/18/2011 04:05 PM, Kirill A. Shutemov wrote:
> >>> On Sun, Sep 18, 2011 at 12:39:12AM -0300, Glauber Costa wrote:
> >>>>> Always zero in root cgroup?
> >>>>
> >>>> Yes, if we're not accounting, it should be zero. WARN_ON, maybe?
> >>>
> >>> -ENOSYS?
> >>>
> >> I'd personally prefer WARN_ON. It is good symmetry from userspace PoV to
> >> always be able to get a value out of it. Also, it something goes wrong
> >> and it is not zero for some reason, this will help us find it.
> >
> > What's the point to get non-relevant value?
> > What about -ENOSYS + WARN_ON?
> >
> Well,
> 
> what about not even registering kernel memory files for !root cgroup?

ENOENT works for me ;)

-- 
 Kirill A. Shutemov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/