linux-kernel - RE: [PATCH 1/3] Staging: hv: util: Perform some service specific init/deinit in probe/remove

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 18 Sep 2011 22:26:19 +0000
From:	KY Srinivasan <kys@...rosoft.com>
To:	Joe Perches <joe@...ches.com>
CC:	"gregkh@...e.de" <gregkh@...e.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...uxdriverproject.org" <devel@...uxdriverproject.org>,
	"virtualization@...ts.osdl.org" <virtualization@...ts.osdl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 1/3] Staging: hv: util: Perform some service specific
 init/deinit in probe/remove



> -----Original Message-----
> From: Joe Perches [mailto:joe@...ches.com]
> Sent: Sunday, September 18, 2011 1:53 PM
> To: KY Srinivasan
> Cc: gregkh@...e.de; linux-kernel@...r.kernel.org;
> devel@...uxdriverproject.org; virtualization@...ts.osdl.org; Haiyang Zhang
> Subject: Re: [PATCH 1/3] Staging: hv: util: Perform some service specific
> init/deinit in probe/remove
> 
> On Sun, 2011-09-18 at 10:31 -0700, K. Y. Srinivasan wrote:
> > In preparation for modifying the util driver to fully conform to the
> > Linux Driver Model,
> []
> > diff --git a/drivers/staging/hv/hv_util.c b/drivers/staging/hv/hv_util.c
> []
> >  static const struct hv_vmbus_device_id id_table[] = {
> >  	/* Shutdown guid */
> >  	{ VMBUS_DEVICE(0x31, 0x60, 0x0B, 0X0E, 0x13, 0x52, 0x34, 0x49,
> > -		       0x81, 0x8B, 0x38, 0XD9, 0x0C, 0xED, 0x39, 0xDB) },
> > +		       0x81, 0x8B, 0x38, 0XD9, 0x0C, 0xED, 0x39, 0xDB)
> > +	  .driver_data = (unsigned long)&util_shutdown },
> 
> Isn't this a kernel_ulong_t ?

Yes; but kernel_ulong_t is unsigned long and this code is compiled only in the kernel.

Regards,

K. Y

> 
> > +	  .driver_data = (unsigned long)&util_timesynch },
> 
> etc.
> 
>