linux-kernel - Re: [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110918082626.GA19444@kroah.com>
Date:	Sun, 18 Sep 2011 01:26:26 -0700
From:	Greg KH <greg@...ah.com>
To:	Sergei Shtylyov <sshtylyov@...sta.com>
Cc:	Shaun Kluzek <g0del@...pond.com>, gregkh@...e.de,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB GADGET: u_serial.c: fixed a brace and whitespace
 coding style issue

On Thu, Sep 01, 2011 at 04:53:39PM +0400, Sergei Shtylyov wrote:
> Hello.
> 
> On 31-08-2011 11:22, Shaun Kluzek wrote:
> 
> >Signed-off-by: Shaun Kluzek<g0del@...pond.com>
> >---
> >  drivers/usb/gadget/u_serial.c |    5 +----
> >  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> >diff --git a/drivers/usb/gadget/u_serial.c b/drivers/usb/gadget/u_serial.c
> >index a8aa469..b86022f 100644
> >--- a/drivers/usb/gadget/u_serial.c
> >+++ b/drivers/usb/gadget/u_serial.c
> >@@ -552,11 +552,8 @@ recycle:
> >  	/* Push from tty to ldisc; without low_latency set this is handled by
> >  	 * a workqueue, so we won't get callbacks and can hold port_lock
> >  	 */
> >-	if (tty && do_push) {
> >+	if (tty && do_push)
> >  		tty_flip_buffer_push(tty);
> >-	}
> >-
> 
>    What's wrong with the first empty line here?
> 
> >-

I agree, don't delete all of the spacing here.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/