linux-kernel - Re: Re: [PATCH 07/17] ASoC: twl6040: Lower the initial gains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2033664.fWQvF2IA53@barack>
Date:	Mon, 19 Sep 2011 14:26:31 +0300
From:	Péter Ujfalusi <peter.ujfalusi@...com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Samuel Ortiz <samuel.ortiz@...el.com>,
	Dmitry Torokhov <dtor@...l.ru>, Liam Girdwood <lrg@...com>,
	alsa-devel@...a-project.org, linux-kernel@...r.kernel.org,
	Misael Lopez Cruz <misael.lopez@...com>
Subject: Re: Re: [PATCH 07/17] ASoC: twl6040: Lower the initial gains

On Monday 19 September 2011 12:00:06 Mark Brown wrote:
> On Thu, Sep 15, 2011 at 03:39:29PM +0300, Peter Ujfalusi wrote:
> > The default gains on outputs/inputs are set to 0dB.
> > To be able to handle pop noise better, we need to lower
> > the gains on controls, where it is possible.
> 
> It looks like what you really want to do here is implement support
> having PGAs able to cache the gain the user has set but hold the gain at
> zero while the PGA is disabled.

The twl6040 had support for this, but we did not lowered the initial gain 
after cold power on.
This resulted a pop noise at the first time the audio paths had been used.

> This would be generally useful, a lot
> of older parts liked to have the PGAs muted when powering them.

I have similar implementation (caching of the output gain values) in the 
twl4030 - there the reason was to decrease the power consumption.
We need to have some sort of caching for the gain values, and linking the 
volume controls to DAPM in order to restore, or turn them off at the correct 
time.
In twl4030 case I have custom PGA event handlers for outputs, and I manage the 
individual output amplifiers through them.
Here in twl6040 we also have event handlers to do the ramp up/down on the 
gains. AFAIK some wm* codec have similar code.

I can take a look at these to find a generic way to handle them.

--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/