linux-kernel - Re: [PATCH 3/3] truncate()/ftruncate() fix length argument on ia32 emulation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110919131631.GA2355@osiris.boeblingen.de.ibm.com>
Date:	Mon, 19 Sep 2011 15:16:31 +0200
From:	Heiko Carstens <heiko.carstens@...ibm.com>
To:	Thomas Meyer <thomas@...3r.de>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	linux-arch@...r.kernel.org
Subject: Re: [PATCH 3/3] truncate()/ftruncate() fix length argument on ia32
 emulation.

On Sat, Sep 17, 2011 at 08:01:17PM +0200, Thomas Meyer wrote:
> move signed-extended int to long, because of signed test.
> 
> Signed-off-by: Thomas Meyer <thomas@...3r.de>

[...]

> +asmlinkage long compat_sys_ftruncate(unsigned int fd, int length)
> +{
> +	return sys_ftruncate(fd, length);
> +}

That seems to be wrong... just look at this patch I sent two years
ago (which btw. introduced the compat truncate sign extension bug
on some architecutures).

http://www.spinics.net/lists/linux-arch/msg08633.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/