linux-kernel - Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 19 Sep 2011 17:06:01 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Grant Likely <grant.likely@...retlab.ca>
Cc:	Luciano Coelho <coelho@...com>,
	Randy Dunlap <rdunlap@...otime.net>,
	matti.j.aaltonen@...ia.com, johannes@...solutions.net,
	linux-kernel@...r.kernel.org, sameo@...ux.intel.com,
	mchehab@...radead.org, linux-media@...r.kernel.org,
	linux-omap@...r.kernel.org, Jean Delvare <khali@...ux-fr.org>,
	Tony Lindgren <tony@...mide.com>
Subject: Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE

On Thursday 15 September 2011, Grant Likely wrote:
> > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> > index 21574bd..1836cdf 100644
> > --- a/drivers/mfd/Kconfig
> > +++ b/drivers/mfd/Kconfig
> > @@ -2,10 +2,9 @@
> >  # Multifunction miscellaneous devices
> >  #
> >  
> > -menuconfig MFD_SUPPORT
> > -     bool "Multifunction device drivers"
> > +menuconfig MFD_CORE
> > +     tristate "Multifunction device drivers"
> >       depends on HAS_IOMEM
> > -     default y
> 
> Looks like there is a bug here.  Kconfig symbols with dependencies
> (HAS_IOMEM) must not ever be selected by other symbols because Kconfig
> doesn't implement a way to resolve them.  This patch means that every
> "select MFD_CORE" just assumes that HAS_IOMEM is also selected.

That is probably a fair assumption though. Almost all architectures
set HAS_IOMEM unconditionally, and the other ones (probably just s390)
would not select MFD_CORE.

Note that Samuel already took the other patch in the end, so it doesn't
matter. The patch I posted encloses the entire directory in "if HAS_IOMEM".

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/