linux-kernel - Re: [PATCH 1/2] posix-timers: move global timer id management to signal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E77CC0E.2090206@linux.intel.com>
Date:	Mon, 19 Sep 2011 16:11:10 -0700
From:	Andi Kleen <ak@...ux.intel.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	Andi Kleen <andi@...stfloor.org>, tglx@...utronix.de,
	linux-kernel@...r.kernel.org, akpm@...ux-foundation.org
Subject: Re: [PATCH 1/2] posix-timers: move global timer id management to
 signal_struct v4

> I'll provide not a hack but a clean patch for this.

Great thanks.
> I read once idr code, and its not messy at all.
You're not serious right? Especially the locking scheme is just
a extreme mess:

sometimes takes a lock, sometimes requires locking from the caller
even though the internal lock should be fine, sometimes uses unlocked 
bitmap
operations outside a lock, all mixed with a partial RCU implementation,
no assumption is documented of course.  etc.etc. It's a great poster child
for messy kernel code.

I read the code and I would be afraid touching it.

-Andi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/