linux-kernel - Re: [RFC][PATCH 1/5] x86: Remove const_udelay() caring about which cpu var it uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1316475092.29966.0.camel@gandalf.stny.rr.com>
Date:	Mon, 19 Sep 2011 19:31:32 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Christoph Lameter <cl@...two.org>
Cc:	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Christoph Lameter <cl@...ux.com>
Subject: Re: [RFC][PATCH 1/5] x86: Remove const_udelay() caring about which
 cpu var it uses

On Mon, 2011-09-19 at 16:51 -0500, Christoph Lameter wrote:
> On Mon, 19 Sep 2011, Steven Rostedt wrote:
> 
> > The __const_udelay() code originally used raw_smp_processor_id()
> > in its calculations for a delaying. Probably because if it were
> > to migrate, it would take much longer to do so than the requested
> > delay.
> >
> > Switch from this_cpu_read() to __this_cpu_read() to document that
> > the read is racy and we do not care.
> 
> Is preemption disabled by all callers to __const_udelay?

Nope, because I triggered a splat with it :-) From lots of places.

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/