linux-kernel - Re: [patch 5/8] Platform: Fix error path in samsung-laptop init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANq1E4TNagJzwLdUXTtR6ZGNJnbb6ppoP0-7mAoN7JUUTYpAVg@mail.gmail.com>
Date:	Tue, 20 Sep 2011 14:21:54 +0200
From:	David Herrmann <dh.herrmann@...glemail.com>
To:	gregkh@...e.de
Cc:	Matthew Garrett <mjg@...hat.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org,
	greg@...ah.com, stable <stable@...nel.org>
Subject: Re: [patch 5/8] Platform: Fix error path in samsung-laptop init

Hi Greg

On Fri, Sep 2, 2011 at 12:50 AM,  <gregkh@...e.de> wrote:
> samsung_init() should not return success if not all devices are initialized.
> Otherwise, samsung_exit() will dereference sdev NULL pointers and others.
>
> Signed-off-by: David Herrmann <dh.herrmann@...glemail.com>
> Cc: stable <stable@...nel.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> ---
>  drivers/platform/x86/samsung-laptop.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> --- a/drivers/platform/x86/samsung-laptop.c
> +++ b/drivers/platform/x86/samsung-laptop.c
> @@ -799,7 +799,7 @@ static int __init samsung_init(void)
>        sabi_iface = ioremap_nocache(ifaceP, 16);
>        if (!sabi_iface) {
>                pr_err("Can't remap %x\n", ifaceP);
> -               goto exit;
> +               goto error_no_signature;
>        }
>        if (debug) {
>                printk(KERN_DEBUG "ifaceP = 0x%08x\n", ifaceP);
> @@ -851,7 +851,6 @@ static int __init samsung_init(void)
>        if (retval)
>                goto error_file_create;
>
> -exit:
>        return 0;
>
>  error_file_create:
>
>
>

"From: " line is missing in this patch and several others of this
series. "git am" applies them with an email only so Matthew needs to
fix them when applying them or you could just resend them with
git-format-patch?

Thanks and regards
David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/