linux-kernel - RE: [PATCH V10 3/6] mm: frontswap: core frontswap functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a7471ea9-1d24-452a-8e3b-eb5836e8e7d5@default>
Date:	Tue, 20 Sep 2011 11:28:21 -0700 (PDT)
From:	Dan Magenheimer <dan.magenheimer@...cle.com>
To:	Seth Jennings <sjenning@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org, jeremy@...p.org,
	hughd@...gle.com, ngupta@...are.org,
	Konrad Wilk <konrad.wilk@...cle.com>, JBeulich@...ell.com,
	Kurt Hackel <kurt.hackel@...cle.com>, npiggin@...nel.dk,
	akpm@...ux-foundation.org, riel@...hat.com, hannes@...xchg.org,
	matthew@....cx, Chris Mason <chris.mason@...cle.com>,
	kamezawa.hiroyu@...fujitsu.com, jackdachef@...il.com,
	cyclonusj@...il.com, levinsasha928@...il.com
Subject: RE: [PATCH V10 3/6] mm: frontswap: core frontswap functionality

> From: Seth Jennings [mailto:sjenning@...ux.vnet.ibm.com]
> Sent: Friday, September 16, 2011 9:12 AM
> To: Dan Magenheimer
> Cc: linux-kernel@...r.kernel.org; linux-mm@...ck.org; jeremy@...p.org; hughd@...gle.com;
> ngupta@...are.org; Konrad Wilk; JBeulich@...ell.com; Kurt Hackel; npiggin@...nel.dk; akpm@...ux-
> foundation.org; riel@...hat.com; hannes@...xchg.org; matthew@....cx; Chris Mason;
> kamezawa.hiroyu@...fujitsu.com; jackdachef@...il.com; cyclonusj@...il.com; levinsasha928@...il.com
> Subject: Re: [PATCH V10 3/6] mm: frontswap: core frontswap functionality
> 
> On 09/15/2011 04:34 PM, Dan Magenheimer wrote:
> > From: Dan Magenheimer <dan.magenheimer@...cle.com>
> > Subject: [PATCH V10 3/6] mm: frontswap: core frontswap functionality
> >
> > [v10: sjenning@...ux.vnet.ibm.com: fix debugfs calls on 32-bit]
> ...
> > +#ifdef CONFIG_DEBUG_FS
> > +	struct dentry *root = debugfs_create_dir("frontswap", NULL);
> > +	if (root == NULL)
> > +		return -ENXIO;
> > +	debugfs_create_u64("gets", S_IRUGO, root, &frontswap_gets);
> > +	debugfs_create_u64("succ_puts", S_IRUGO, root, &frontswap_succ_puts);
> > +	debugfs_create_u64("puts", S_IRUGO, root, &frontswap_failed_puts);
> 
> Sorry I didn't see this one before :-/  This should be "failed_puts",
> not "puts".

Oops, thought I had replied to this but hadn't.

Thanks for catching that typo.  Unless someone reports something
else that needs fixing, I will likely just fix that in my git tree
rather than post a V11.
 
> Other than that, it compiles cleanly here and runs without issue when
> applied on 3.1-rc4 + fix for cleancache crash.

Thanks for the testing!

Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/