| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4E78FAE6.6080903@xenotime.net> Date: Tue, 20 Sep 2011 13:43:18 -0700 From: Randy Dunlap <rdunlap@...otime.net> To: Rafał Miłecki <zajec5@...il.com> CC: Andrew Morton <akpm@...ux-foundation.org>, Stephen Rothwell <sfr@...b.auug.org.au>, linux-next@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org> Subject: Re: [PATCH -next] bcma: needs export.h On 09/20/2011 11:45 AM, Rafał Miłecki wrote: > 2011/9/20 Randy Dunlap <rdunlap@...otime.net>: >> From: Randy Dunlap <rdunlap@...otime.net> >> >> bcma/driver_chipcommon_pmu.c needs to include <linux/export.h>, >> so add it to the headers that are included by bcma_private.h. > > Please take a look at discussion in: > [PATCH -next] bcma: main.c needs to include <linux/slab.h> > thread (by Andrew). > > I believe that according to the discussion, such a includes should be > done in .c files. > > Andrew: can you comment? Am I right? Sure, I'll resubmit the patch. Is there already a patch to remove <linux/delay.h> from bcma_private.h ? bcma_private.h uses __init & __exit, so it should #include <linux/init.h> ... -- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists