linux-kernel - Re: [PATCH v1 4/4] target: check hex2bin result

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VcQd9CjCKHVWjb7pDzFWCHMTcpTrzG4hHfiLu27F+Tfmg@mail.gmail.com>
Date:	Wed, 21 Sep 2011 02:55:35 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	Arnaud Lacombe <lacombar@...il.com>,
	James Morris <jmorris@...ei.org>,
	David Safford <safford@...son.ibm.com>
Subject: Re: [PATCH v1 4/4] target: check hex2bin result

On Tue, Sep 20, 2011 at 10:52 PM, Mimi Zohar <zohar@...ux.vnet.ibm.com> wrote:
> Now that hex2bin does error checking, on error add debugging error msg.
>
> Changelog v1:
> - hex2bin now returns an int
>
> Signed-off-by: Mimi Zohar <zohar@...ux.vnet.ibm.com>
> ---
>  drivers/target/target_core_fabric_lib.c |   11 +++++++++--
>  1 files changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/target/target_core_fabric_lib.c b/drivers/target/target_core_fabric_lib.c
> index c4ea3a9..17658ca 100644
> --- a/drivers/target/target_core_fabric_lib.c
> +++ b/drivers/target/target_core_fabric_lib.c
> @@ -63,6 +63,7 @@ u32 sas_get_pr_transport_id(
>        unsigned char *buf)
>  {
>        unsigned char *ptr;
> +       bool ret;
I'm sorry for this, but I guess you meant int?
>
>        /*
>         * Set PROTOCOL IDENTIFIER to 6h for SAS

> @@ -158,6 +161,8 @@ u32 fc_get_pr_transport_id(
>        unsigned char *ptr;
>        int i;
>        u32 off = 8;
> +       bool ret;
Ditto.
> +
>        /*
>         * PROTOCOL IDENTIFIER is 0h for FCP-2
>         *
Otherwise have my Acked-by. I think Andrew also will be happy.


-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/