linux-kernel - Re: [PATCH 1/1] Trivial: Eliminate the ret variable from mm_take_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110920071408.GB26791@tiehlicka.suse.cz>
Date:	Tue, 20 Sep 2011 09:14:08 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	Kautuk Consul <consul.kautuk@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrea Arcangeli <aarcange@...hat.com>,
	Shaohua Li <shaohua.li@...el.com>,
	Jiri Kosina <trivial@...nel.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] Trivial: Eliminate the ret variable from
 mm_take_all_locks

On Tue 13-09-11 15:55:31, Kautuk Consul wrote:
> The ret variable is really not needed in mm_take_all_locks as per
> the current flow of the mm_take_all_locks function.
> 
> So, eliminating this return variable.
> 
> Signed-off-by: Kautuk Consul <consul.kautuk@...il.com>

The compiled code seems to be very same - compilers are clever enough to
reorganize the code but anyway the code reads better this way.

Reviewed-by: Michal Hocko <mhocko@...e.cz>

> ---
>  mm/mmap.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/mm/mmap.c b/mm/mmap.c
> index a65efd4..48bc056 100644
> --- a/mm/mmap.c
> +++ b/mm/mmap.c
> @@ -2558,7 +2558,6 @@ int mm_take_all_locks(struct mm_struct *mm)
>  {
>  	struct vm_area_struct *vma;
>  	struct anon_vma_chain *avc;
> -	int ret = -EINTR;
>  
>  	BUG_ON(down_read_trylock(&mm->mmap_sem));
>  
> @@ -2579,13 +2578,12 @@ int mm_take_all_locks(struct mm_struct *mm)
>  				vm_lock_anon_vma(mm, avc->anon_vma);
>  	}
>  
> -	ret = 0;
> +	return 0;
>  
>  out_unlock:
> -	if (ret)
> -		mm_drop_all_locks(mm);
> +	mm_drop_all_locks(mm);
>  
> -	return ret;
> +	return -EINTR;
>  }
>  
>  static void vm_unlock_anon_vma(struct anon_vma *anon_vma)
> -- 
> 1.7.6
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>

-- 
Michal Hocko
SUSE Labs
SUSE LINUX s.r.o.
Lihovarska 1060/12
190 00 Praha 9    
Czech Republic
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/