linux-kernel - Re: [PATCH 4/7] perf, x86: Implement IBS interrupt handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110921083951.GY6063@erda.amd.com>
Date:	Wed, 21 Sep 2011 10:39:51 +0200
From:	Robert Richter <robert.richter@....com>
To:	Peter Zijlstra <peterz@...radead.org>
CC:	Ingo Molnar <mingo@...e.hu>, Stephane Eranian <eranian@...gle.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/7] perf, x86: Implement IBS interrupt handler

On 14.09.11 12:13:25, Peter Zijlstra wrote:
> On Wed, 2011-09-07 at 18:36 +0200, Robert Richter wrote:
> > +       if (event->attr.sample_type & PERF_SAMPLE_RAW) {
> > +               ibs_data.caps = ibs_caps;
> > +               size = 1;
> > +               offset = 1;
> > +               do {
> > +                   rdmsrl(msr + offset, *buf++);
> > +                   size++;
> > +                   offset = find_next_bit(perf_ibs->offset_mask,
> > +                                          perf_ibs->offset_max,
> > +                                          offset + 1);
> > +               } while (offset < perf_ibs->offset_max);
> > +               raw.size = sizeof(u32) + sizeof(u64) * size;
> > +               raw.data = ibs_data.data;
> > +               data.raw = &raw;
> > +       } 
> 
> Another application of for_each_set_bit_continue() ?

Peter, I will make this a separate patch set to decouple from this
patch set. Will then update this code too. So in my next ibs patch set
I wont change this here.

-Robert

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/