linux-kernel - Re: [PATCH] x86_64: permit to configure ISA support also for x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <11382509.BgAkVknI9a@wuerfel>
Date:	Wed, 21 Sep 2011 11:24:44 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Wolfgang Grandegger <wg@...ndegger.com>
Cc:	SocketCAN Core Mailing List <socketcan-core@...ts.berlios.de>,
	Willy Lambert <lambert.willy@...il.com>, x86@...nel.org,
	Valdis.Kletnieks@...edu, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86_64: permit to configure ISA support also for x86_64 systems

On Wednesday 21 September 2011 10:33:10 Wolfgang Grandegger wrote:
> 
> > Since most ISA drivers don't actually use isa_register_driver
> > (for good or bad), how about changing the Kconfig entry for
> > the ones you need to 'depends on ISA || PLAT_GRANDEGGER_PC104_ATOM'
> > or similar?
> 
> What should the PLAT_GRANDEGGER_PC104_ATOM be good for? If I replace
> isa_register_driver() with platform_driver_register(), like the serial
> 8250 driver does, HAS_IOMEM should be just fine. This would then also
> avoid the 64-bit trouble expected with old ISA drivers (enabled via
> ISA). Or have I missed something?

I was thinking of the drivers that are for ISA cards but don't actually
use the isa_register_driver() function. If you have to change the driver
to a platform driver, you are right.

The other point is that you are probably using inb/outb operations,
which I'm trying to provide only on ISA/PCMCIA/PCI based systems in
the future. Once I finish that work, you will also need to depend on
HAS_IOPORT (which currently means something else).

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/