linux-kernel - Re: xen_biovec_phys_mergeable not exported

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110921184630.GI17357@phenom.oracle.com>
Date:	Wed, 21 Sep 2011 14:46:30 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Jens Axboe <axboe@...nel.dk>
Cc:	Matthew Wilcox <matthew@....cx>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: xen_biovec_phys_mergeable not exported

On Wed, Sep 21, 2011 at 02:09:40PM +0200, Jens Axboe wrote:
> On 2011-09-20 22:25, Matthew Wilcox wrote:
> > 
> > In my NVMe driver, I call BIOVEC_PHYS_MERGEABLE().  If CONFIG_XEN
> > is defined, it references xen_biovec_phys_mergeable() which is not
> > EXPORT_SYMBOL.  I think BIOVEC_PHYS_MERGABLE is a perfectly kosher thing
> > to be calling from a module that implements a bio-based block driver,
> > so I think the right thing to do is to add an EXPORT_SYMBOL(_GPL?) to
> > the Xen code when I submit the driver.

I am OK with that.
> > 
> > Does anyone have a different opinion on this?
> 
> Yep, lets just export it for now. Long term, that functionality will be
> moving back into the block layer when we unify the queuing models.
> 
> -- 
> Jens Axboe
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/