linux-kernel - Re: [PATCH 43/57] PNP: irq: Remove IRQF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAErSpo7VR8+AGgWABb2c0uU_bgcmg43dxui41JFzmCQPvC7bGg@mail.gmail.com>
Date:	Wed, 21 Sep 2011 14:20:46 -0600
From:	Bjorn Helgaas <bhelgaas@...gle.com>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, Adam Belay <abelay@....edu>
Subject: Re: [PATCH 43/57] PNP: irq: Remove IRQF_DISABLED

On Wed, Sep 21, 2011 at 3:28 AM, Yong Zhang <yong.zhang0@...il.com> wrote:
> Since commit [c58543c8: genirq: Run irq handlers with interrupts disabled],
> We run all interrupt handlers with interrupts disabled
> and we even check and yell when an interrupt handler
> returns with interrupts enabled (see commit [b738a50a:
> genirq: Warn when handler enables interrupts]).
>
> So now this flag is a NOOP and can be removed.
>
> Signed-off-by: Yong Zhang <yong.zhang0@...il.com>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

> ---
>  drivers/pnp/resource.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/pnp/resource.c b/drivers/pnp/resource.c
> index b0ecacb..3669821 100644
> --- a/drivers/pnp/resource.c
> +++ b/drivers/pnp/resource.c
> @@ -385,7 +385,7 @@ int pnp_check_irq(struct pnp_dev *dev, struct resource *res)
>         * device is active because it itself may be in use */
>        if (!dev->active) {
>                if (request_irq(*irq, pnp_test_handler,
> -                               IRQF_DISABLED | IRQF_PROBE_SHARED, "pnp", NULL))
> +                               IRQF_PROBE_SHARED, "pnp", NULL))
>                        return 0;
>                free_irq(*irq, NULL);
>        }
> --
> 1.7.4.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/