linux-kernel - Re: [PATCH] kconfig: fix set but not used variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACqU3MUNX0VuktboqYA6FxuaHHgqrX=kjNrqGODThFfqg8_61w@mail.gmail.com>
Date:	Wed, 21 Sep 2011 17:30:05 -0400
From:	Arnaud Lacombe <lacombar@...il.com>
To:	Lucas De Marchi <lucas.demarchi@...fusion.mobi>
Cc:	Michal Marek <mmarek@...e.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kconfig: fix set but not used variables

Hi,

On Wed, Sep 21, 2011 at 4:15 PM, Lucas De Marchi
<lucas.demarchi@...fusion.mobi> wrote:
> Hi Michal
>
> On Sat, Aug 20, 2011 at 2:28 AM, Lucas De Marchi
> <lucas.demarchi@...fusion.mobi> wrote:
>> Some variables were being set but never used, which was triggering
>> warnings in GCC >= 4.6.
>>
>> Signed-off-by: Lucas De Marchi <lucas.demarchi@...fusion.mobi>
>> ---
>>  scripts/kconfig/lxdialog/textbox.c |    3 +--
>>  1 files changed, 1 insertions(+), 2 deletions(-)
>>
>> diff --git a/scripts/kconfig/lxdialog/textbox.c b/scripts/kconfig/lxdialog/textbox.c
>> index c704712..154c2dd 100644
>> --- a/scripts/kconfig/lxdialog/textbox.c
>> +++ b/scripts/kconfig/lxdialog/textbox.c
>> @@ -320,7 +320,6 @@ static void print_page(WINDOW * win, int height, int width)
>>  */
>>  static void print_line(WINDOW * win, int row, int width)
>>  {
>> -       int y, x;
>>        char *line;
>>
>>        line = get_line();
>> @@ -329,10 +328,10 @@ static void print_line(WINDOW * win, int row, int width)
>>        waddch(win, ' ');
>>        waddnstr(win, line, MIN(strlen(line), width - 2));
>>
>> -       getyx(win, y, x);
>>        /* Clear 'residue' of previous line */
>>  #if OLD_NCURSES
>>        {
>> +               int x = getcurx(win);
>>                int i;
>>                for (i = 0; i < width - x; i++)
>>                        waddch(win, ' ');
>> --
>> 1.7.6
>
> Did you apply this patch?
>
I picked it in my tree while Michal was AFK. He later on merged that
in his tree.

 - Arnaud
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/