linux-kernel - Re: [PATCH 1/6] toshiba_acpi: Convert to use acpi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHR064iA1877cF1rmUhX_41U_yjRGs6siswpoMPjs=WEYEm8cQ@mail.gmail.com>
Date:	Wed, 21 Sep 2011 09:28:30 +0200
From:	Corentin Chary <corentin.chary@...il.com>
To:	Seth Forshee <seth.forshee@...onical.com>
Cc:	Matthew Garrett <mjg@...hat.com>,
	Azael Avalos <coproscefalo@...il.com>,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/6] toshiba_acpi: Convert to use acpi_driver

On Tue, Sep 20, 2011 at 11:55 PM, Seth Forshee
<seth.forshee@...onical.com> wrote:
> Changes toshiba_acpi to register an acpi driver and eliminates the
> platform device it was using.

Why to you want to remove the platform device ? If you want to create
a sysfs interface later, you'll probably need it. Most of the platform
driver I know only use the acpi_device to send proc/netlink events and
the platform_device is used everywhere else. (And anyway, it's an x86
*platform* driver, not a pure acpi driver).

> Also eliminates most global
> variables, moving them into toshiba_acpi_dev, along with some
> other miscellaneous fixes and cleanup.

Good ! Next step would be to deprecate the /proc interface (keeping it
for compatibility) and adding a new shinny
/sys/platform/device/toshiba-acpi/ interface correctly documented in
Documentation/ABI/ :).

Thanks,

-- 
Corentin Chary
http://xf.iksaif.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/