linux-kernel - Re: [PATCH] ARM: pxa/cm-x300: properly set bt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4E7B0E35.5010607@compulab.co.il>
Date:	Thu, 22 Sep 2011 13:30:13 +0300
From:	Igor Grinberg <grinberg@...pulab.co.il>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org,
	Russell King <linux@....linux.org.uk>,
	Eric Miao <eric.y.miao@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] ARM: pxa/cm-x300: properly set bt_reset pin

Hi Axel,

On 09/17/11 17:15, Axel Lin wrote:
> Fix below build warning and properly set bt_reset pin.
> 
>   CC      arch/arm/mach-pxa/cm-x300.o
> arch/arm/mach-pxa/cm-x300.c: In function 'cm_x300_init_wi2wi':
> arch/arm/mach-pxa/cm-x300.c:779: warning: unused variable 'wlan_en'
> arch/arm/mach-pxa/cm-x300.c:795: warning: 'bt_reset' may be used uninitialized in this function

What a shame...
My patch 5a009df1f200efa49658b0e9c7ad056d59fbefe4
(ARM: pxa/cm-x300: GPIO cleanup) was f*cked up, sorry...
I should have not send it in a rush and I admit,
I had no possibility to test it. Sorry again...

> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Thanks for spotting this.

Acked-by: Igor Grinberg <grinberg@...pulab.co.il>

Also, this patch fixes a real regression since
5a009df1f200efa49658b0e9c7ad056d59fbefe4 (ARM: pxa/cm-x300: GPIO cleanup)
- Wifi and Bluetooth do not work without it, so please:

Cc: <stable@...nel.org> [3.0.x]

> ---
>  arch/arm/mach-pxa/cm-x300.c |    8 +++-----
>  1 files changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-pxa/cm-x300.c b/arch/arm/mach-pxa/cm-x300.c
> index 0f00e01..0e18eb9 100644
> --- a/arch/arm/mach-pxa/cm-x300.c
> +++ b/arch/arm/mach-pxa/cm-x300.c
> @@ -776,7 +776,6 @@ static struct gpio cm_x300_wi2wi_gpios[] __initdata = {
>  
>  static void __init cm_x300_init_wi2wi(void)
>  {
> -	int bt_reset, wlan_en;
>  	int err;
>  
>  	if (system_rev < 130) {
> @@ -792,12 +791,11 @@ static void __init cm_x300_init_wi2wi(void)
>  	}
>  
>  	udelay(10);
> -	gpio_set_value(bt_reset, 0);
> +	gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 0);
>  	udelay(10);
> -	gpio_set_value(bt_reset, 1);
> +	gpio_set_value(cm_x300_wi2wi_gpios[1].gpio, 1);
>  
> -	gpio_free(wlan_en);
> -	gpio_free(bt_reset);
> +	gpio_free_array(ARRAY_AND_SIZE(cm_x300_wi2wi_gpios));
>  }
>  
>  /* MFP */

-- 
Regards,
Igor.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/