linux-kernel - Re: [PATCH] acpi: Fix possible recursive locking in hwregs.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADZ9YHhk0idJ6DQOfGmHJtY2RrHyk=D_m-wcOgN1rPp7_ommBg@mail.gmail.com>
Date:	Thu, 22 Sep 2011 09:35:23 +0600
From:	Rakib Mullick <rakib.mullick@...il.com>
To:	Lin Ming <ming.m.lin@...el.com>
Cc:	linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-acpi@...r.kernel.org, Bob Moore <robert.moore@...el.com>
Subject: Re: [PATCH] acpi: Fix possible recursive locking in hwregs.c

On Thu, Sep 22, 2011 at 6:59 AM, Lin Ming <ming.m.lin@...el.com> wrote:
> On Thu, Sep 22, 2011 at 2:09 AM, Rakib Mullick <rakib.mullick@...il.com> wrote:
>> Calling pm-suspend might trigger a recursive lock in it's code path. In function acpi_hw_clear_acpi_status,
>> acpi_os_release_lock holds the lock acpi_gbl_hardware_lock before calling acpi_hw_register_write(), then
>> without releasing acpi_gbl_hardware_lock, this function calls acpi_ev_walk_gpe_list, which also tries to
>> hold acpi_gbl_hardware_lock and thus causes possible recursive lock.
>
> No, acpi_ev_walk_gpe_list holds acpi_gbl_gpe_lock.
>
Yes, right. Actually, acpi_os_release_lock() tries to hold
acpi_gbl_gpe_lock without releasing acpi_gbl_hardware_lock. Right?

Thanks,
Rakib
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/