linux-kernel - RE: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6F5C1D715B2DA5498A628E6B9C124F0401CB6A33EC@hasmsx504.ger.corp.intel.com>
Date:	Fri, 23 Sep 2011 00:10:53 +0300
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg KH <greg@...ah.com>
CC:	"Weil, Oren jer" <oren.jer.weil@...el.com>,
	"gregkh@...e.de" <gregkh@...e.de>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.

> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Thursday, September 22, 2011 11:18 PM
> To: Winkler, Tomas
> Cc: Weil, Oren jer; gregkh@...e.de; devel@...verdev.osuosl.org; linux-
> kernel@...r.kernel.org
> Subject: Re: [PATCH 2/2] staging: mei: clean the TODO file from done tasks.
> 
> On Thu, Sep 22, 2011 at 11:11:38PM +0300, Winkler, Tomas wrote:
> >
> >
> > > -----Original Message-----
> > > From: Greg KH [mailto:greg@...ah.com]
> > > Sent: Thursday, September 22, 2011 10:55 PM
> > > To: Winkler, Tomas
> > > Cc: Weil, Oren jer; gregkh@...e.de; devel@...verdev.osuosl.org;
> > > linux- kernel@...r.kernel.org
> > > Subject: Re: [PATCH 2/2] staging: mei: clean the TODO file from done
> tasks.
> 
> Again, please fix your email client.
> 
> > > > Please start here
> > > > http://software.intel.com/en-us/blogs/2011/06/01/new-updated-intel
> > > > r-
> > > am
> > > > t-linux-drivers/
> > >
> > > That's a pointer to the same driver that is already in the kernel tree, right?
> > > What am I missing here?
> >
> > There is LMS there but I guess this links is more updated, they call it driver
> but actually it is a user space daemon.
> >
> > Anyhow this one should be the latest one
> > http://software.intel.com/en-us/articles/download-the-latest-intel-amt
> > -open-source-drivers/?wapkw=%28Linux+AMT%29
> > It also provides ACU.
> 
> What is "ACU"?
This is actually cli to work with ME,  all the docs can be found through that links.

I guess this is all quite complex, there is  Linux Enablement Guide on the link above it should be useful, 
yet we probably need to think to make something simple for reviewer also run the code in simple way...

> 
> Anyway, we want a good description of just what this driver is exporting to
> userspace, and how it is doing it.  That's the important part here, and is what
> we need to be able to properly review the code if you wish to start the
> process to move out of drivers/staging/

Yes I understand that and hoped we addressed that in mei.txt and patch0. 
Can you please comment directly on mei.txt what is not clear there or are you suggesting 
other form of documentation. We will also review it again and will address your ABI comments.

Briefly since this is all in mei.txt 

MEI provides nothing mere just a tunnel between user space and MEI firmware.
There are many features that MEI firmware can provide and each has its own rich API (we call it also protocol)
 The specific API documentation is available from link in the mei.txt (we need to fill the place holder actually)
The exceptions are Watchdog which is in kernel, talking to MEI firmware watchdog feature. Now it exposes standard
Watchdog Linux API, and AMTHI which just provides multiplexing between more than one user space application for AMTHI feature.

There is only one in/out ioctl  IOCTL_MEI_CONNECT_CLIENT, which after opening /dev/mei specifies which firmware feature we are going talk to.
Client is specified by UUID.  List of UUIDs is not part of the kernel API  (only the wd and amthi are visible in the code), this is up to the application to
to know what client it want to talk to it. 

Thanks
Tomas

---------------------------------------------------------------------
Intel Israel (74) Limited

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/