linux-kernel - Re: [PATCH] perf: make perf.data more self-descriptive (v5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m2pqisjmtw.fsf@firstfloor.org>
Date:	Thu, 22 Sep 2011 14:20:43 -0700
From:	Andi Kleen <andi@...stfloor.org>
To:	Stephane Eranian <eranian@...gle.com>
Cc:	linux-kernel@...r.kernel.org, acme@...hat.com,
	peterz@...radead.org, mingo@...e.hu, dsahern@...il.com,
	robert.richter@....com
Subject: Re: [PATCH] perf: make perf.data more self-descriptive (v5)

Stephane Eranian <eranian@...gle.com> writes:

> The goal of this patch is to include more information
> about the host environment into the perf.data so it is
> more self-descriptive. Overtime, profiles are captured
> on various machines and it becomes hard to track what
> was recorded, on what machine and when.

I read it near completely.

The only weird thing were the .byte coded push/pops 
in CPUID.

Also the /proc parser doesn't seem very robust, 
e.g. strstr is not a good way to check for a field.

And the code reading /proc lines with fgets should
likely use getline()

Then the bswap code would be much nicer inside a macro.

Other than that it looks good.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/