linux-kernel - Re: [PATCH v3 3/3] OMAP3: Remove auto-selection of PMICs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110922222517.GX2937@atomide.com>
Date:	Thu, 22 Sep 2011 15:25:17 -0700
From:	Tony Lindgren <tony@...mide.com>
To:	Kevin Hilman <khilman@...com>
Cc:	Abhilash K V <abhilash.kv@...com>, linux-omap@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux@....linux.org.uk, sameo@...ux.intel.com,
	christian.gmeiner@...il.com, santosh.shilimkar@...com,
	premi@...com, david.woodhouse@...el.com
Subject: Re: [PATCH v3 3/3] OMAP3: Remove auto-selection of PMICs

* Kevin Hilman <khilman@...com> [110922 14:30]:
> Abhilash K V <abhilash.kv@...com> writes:
> 
> > The current implementation almost assumes that only
> 
> almost?  ;)
> 
> > TWL4030/TWL5030/TWl6030 are (or can be) used with the
> > OMAP processors. This is, however, not true.
> >
> > This patch removes the automatic selection of the PMIC
> > from Kconfig.
> > All currently used PMICs are now added to omap2plus_defconfig;
> 
> I don't think adding them to omap2plus_defconfig is right either, as
> those will get stripped out the next time that file is (re)generated.
> 
> > any new PMIC that gets supported in future could now be
> > enabled here rather than by changing Kconfig for
> > ARCH_OMAP2PLUS_TYPICAL
> 
> IMO, the right fix is to have the board Kconfig entries select the PMIC
> being used on those boards.  That is the only solution that will scale,
> and also work when using 'make randconfig'.

Agreed.

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/