linux-kernel - Re: [PATCH] drivers/tty: don't use the byte channel handle as a parameter in ehv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 22 Sep 2011 16:06:40 -0700
From:	Greg KH <greg@...ah.com>
To:	Timur Tabi <timur@...escale.com>
Cc:	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org,
	linux-console@...r.kernel.org
Subject: Re: [PATCH] drivers/tty: don't use the byte channel handle as a
 parameter in ehv_bytechan.c

On Tue, Sep 20, 2011 at 01:26:57PM -0500, Timur Tabi wrote:
> The ePAPR hypervisor byte channel console driver only supports one byte
> channel as a console, and the byte channel handle is stored in a global
> variable.  It doesn't make any sense to pass that handle as a parameter
> to the console functions, since these functions already have access to the
> global variable.
> 
> This change also fixes this compilation warning on a 64-bit kernel:
> 
>   CC      drivers/tty/ehv_bytechan.o
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_write':
> drivers/tty/ehv_bytechan.c:289:24: warning: cast from pointer to integer of different size
> drivers/tty/ehv_bytechan.c: In function 'ehv_bc_console_init':
> drivers/tty/ehv_bytechan.c:355:24: warning: cast to pointer from integer of different size
> 
> This warning is because the driver is converting the integer byte channel
> handle to/from the void* 'data' field of struct console.  Rather than fix
> the warning, we just eliminate the code altogether.
> 
> Signed-off-by: Timur Tabi <timur@...escale.com>
> ---
>  drivers/tty/ehv_bytechan.c |    7 ++-----

This patch doesn't apply at all to my tty tree, what was it made
against?

confused,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/