lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 22 Sep 2011 15:56:16 +0800 From: Dongdong Deng <libfetion@...il.com> To: Tim Bird <tim.bird@...sony.com> Cc: linux-kernel@...r.kernel.org, kgdb-bugreport@...ts.sourceforge.net, jason.wessel@...driver.com Subject: Re: [PATCH] debug_core: Add warn message for CONFIG_DEBUG_RODATA enable On Thu, Sep 22, 2011 at 3:50 PM, <libfetion@...il.com> wrote: > From: Dongdong Deng <libfetion@...il.com> > > The CONFIG_DEBUG_RODATA will limit KGDB/KDB's set breakpoint function, > and CONFIG_DEBUG_RODATA and CONFIG_KGDB could survive together. > > Thus most of new user of KGDB/KDB get the set_breakpoint problem > caused by CONFIG_DEBUG_RODATA, and them have to send mail to > kgdb/kdb's mail-list for help. > > This patch just adds an extra printk message to warn above case, > in order to provide some useful diagnostics to kgdb/kdb user. > > Signed-off-by: Dongdong Deng <libfetion@...il.com> > --- > kernel/debug/debug_core.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/kernel/debug/debug_core.c b/kernel/debug/debug_core.c > index bad6786..c2d98c1 100644 > --- a/kernel/debug/debug_core.c > +++ b/kernel/debug/debug_core.c > @@ -899,6 +899,11 @@ int kgdb_register_io_module(struct kgdb_io *new_dbg_io_ops) > if (kgdb_break_asap) > kgdb_initial_breakpoint(); > > +#ifdef CONFIG_DEBUG_RODATA > + printk(KERN_WARNING "kgdb: May need to disable CONFIG_DEBUG_RODATA" > + " in order to set breakpoints.\n"); > +#endif > + > return 0; > } > EXPORT_SYMBOL_GPL(kgdb_register_io_module); > -- > 1.7.1 > Hi Tim, I am thinking about the case of KGDB, not only the KDB. How about this patch? -- add the extra printk message to the debug_core init. When debug_core init, and check the CONFIG_DEBUG_RODATA was enabled, then warn the user that breakpoints will not work... If it is OK to you, could you should Signed-off for this patch. :-) -Dongdong -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists