linux-kernel - Re: [PATCH] tty/n_gsm: fix bug in tiocmset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20110923110520.1119aeb9@lxorguk.ukuu.org.uk>
Date:	Fri, 23 Sep 2011 11:05:20 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Nikola Diklic-Perin <diklic.perin.nikola@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	greg@...ah.com
Subject: Re: [PATCH] tty/n_gsm: fix bug in tiocmset

On Fri, 23 Sep 2011 10:59:43 +0200
Nikola Diklic-Perin <diklic.perin.nikola@...il.com> wrote:

> From: Nikola Diklic-Perin <diklic.perin.nikola@...il.com>
> 
> Clear bitmask was not inverted before masking modem_tx.
> 
> Calling ioctl(fd, TIOCMBIC, TIOCM_RTS) results in:
> 
> [  197.430000] pre_modem_tx:	0x00000006
> [  197.430000] clear:			0x00000004
> [  197.430000] set:			0x00000000
> [  197.440000] post_modem_tx:	0x00000004
> 
> which is wrong.
> 
> Signed-off-by: Nikola Diklic-Perin <diklic.perin.nikola@...il.com>

Acked-by: Alan Cox <alan@...x.intel.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/