[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAGZ=bqJpPOFVbONmRbfww+GYb-9__33wGwbBYN0Gjt+3+w4o5g@mail.gmail.com>
Date: Fri, 23 Sep 2011 13:24:48 -0400
From: Kyle Moffett <kyle@...fetthome.net>
To: Philipp Reisner <philipp.reisner@...bit.com>
Cc: linux-kernel@...r.kernel.org, Jens Axboe <axboe@...nel.dk>,
drbd-dev@...ts.linbit.com
Subject: Re: [PATCH 10/10] drbd: For protocol versions before 100, use mixed
header versions
On Fri, Sep 23, 2011 at 10:31, Philipp Reisner
<philipp.reisner@...bit.com> wrote:
> Previous versions of drbd are using version 80 headers for all packets
> short enough for protocol 80. They support both header versions in
> worker context, but only version 80 headers in asynchronous context.
> For backwards compatibility, continue to use version 80 headers for
> short packets before protocol version 100.
>
> From protocol version 100 on, use the same header version for all
> packets.
If I understand it correctly, this patch fixes a backwards compat bug in
code introduced 2 patches earlier:
[PATCH 08/10] drbd: Introduce protocol version 100 headers
Therefore this patch (and its commit message) should just be rolled into
that one to prevent the bug in the first place.
Cheers,
Kyle Moffett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists