linux-kernel - Re: [PATCH resend] user namespace: usb: make usb urbs user namespace aware (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 23 Sep 2011 14:35:09 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	"Serge E. Hallyn" <serge.hallyn@...onical.com>
cc:	"Serge E. Hallyn" <serge@...lyn.com>, Greg KH <greg@...ah.com>,
	Oleg Nesterov <oleg@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>, <richard@....at>,
	Andrew Morton <akpm@...gle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Tejun Heo <tj@...nel.org>, <linux-usb@...r.kernel.org>
Subject: Re: [PATCH resend] user namespace: usb: make usb urbs user namespace
 aware (v2)

On Fri, 23 Sep 2011, Serge E. Hallyn wrote:

> > > > This should be broken up into two separate patches: One to add
> > > > kill_pid_info_as_cred() and the other to modify the usbfs driver.
> > > 
> > > It seems like that would make the first patch harder to review (since
> > > it won't just show the changes from kill_pid_info_as_uid to
> > > kill_pid_info_as_cred), but I'll go ahead and split it up.  I assume
> > > kill_pid_info_as_uid should be removed in a third patch?
> > 
> > No, what I meant was that all the changes to /kernel/signal.c should be 
> > in one patch and all the changes to drivers/usb/core/devio.c should be 
> > in a second patch.
> 
> But doing that in two patches would not be bisect-safe.

Argh, you're right.

It's not a good idea to combine changes to widely differing subsystems
in a single patch, but luckily this is small enough that it doesn't
matter too much.  If nobody else minds, I won't complain.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/