linux-kernel - [PATCH] ecryptfs/inode.c: local functions should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <201109231333.58042.hartleys@visionengravers.com>
Date:	Fri, 23 Sep 2011 13:33:57 -0700
From:	H Hartley Sweeten <hartleys@...ionengravers.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
CC:	<ecryptfs@...r.kernel.org>, <tyhicks@...ux.vnet.ibm.com>,
	<kirkland@...onical.com>
Subject: [PATCH] ecryptfs/inode.c: local functions should be static

This quiets the following sparse noise:

warning: symbol 'ecryptfs_getattr_link' was not declared. Should it be static?
warning: symbol 'ecryptfs_getattr' was not declared. Should it be static?

Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
Cc: Tyler Hicks <tyhicks@...ux.vnet.ibm.com>
Cc: Dustin Kirkland <kirkland@...onical.com>

---

diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c
index 11f8582..6837d8d 100644
--- a/fs/ecryptfs/inode.c
+++ b/fs/ecryptfs/inode.c
@@ -1017,7 +1017,7 @@ out:
 	return rc;
 }
 
-int ecryptfs_getattr_link(struct vfsmount *mnt, struct dentry *dentry,
+static int ecryptfs_getattr_link(struct vfsmount *mnt, struct dentry *dentry,
 			  struct kstat *stat)
 {
 	struct ecryptfs_mount_crypt_stat *mount_crypt_stat;
@@ -1039,7 +1039,7 @@ int ecryptfs_getattr_link(struct vfsmount *mnt, struct dentry *dentry,
 	return rc;
 }
 
-int ecryptfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
+static int ecryptfs_getattr(struct vfsmount *mnt, struct dentry *dentry,
 		     struct kstat *stat)
 {
 	struct kstat lower_stat;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/