linux-kernel - Re: [PATCH] mm/page_cgroup.c: quiet sparse noise

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKTCnznRZbcsnHyV=+-DDd2fkAZ+kqyqrCoos+4ZmBxGBPNQYg@mail.gmail.com>
Date:	Fri, 23 Sep 2011 11:22:08 +0530
From:	Balbir Singh <bsingharora@...il.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, linux-mm@...ck.org,
	containers@...ts.linux-foundation.org, paul@...lmenage.org,
	lizf@...fujitsu.com, nishimura@....nes.nec.co.jp,
	kamezawa.hiroyu@...fujitsu.com
Subject: Re: [PATCH] mm/page_cgroup.c: quiet sparse noise

On Fri, Sep 23, 2011 at 6:45 AM, H Hartley Sweeten
<hartleys@...ionengravers.com> wrote:
> Quite the sparse noise:
>
> warning: symbol 'swap_cgroup_ctrl' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Paul Menage <paul@...lmenage.org>
> Cc: Li Zefan <lizf@...fujitsu.com>
> Cc: Balbir Singh <bsingharora@...il.com>
> Cc: Daisuke Nishimura <nishimura@....nes.nec.co.jp>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>
> ---
>
> diff --git a/mm/page_cgroup.c b/mm/page_cgroup.c
> index 6bdc67d..eead840 100644
> --- a/mm/page_cgroup.c
> +++ b/mm/page_cgroup.c
> @@ -357,7 +357,7 @@ struct swap_cgroup_ctrl {
>        spinlock_t      lock;
>  };
>
> -struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];
> +static struct swap_cgroup_ctrl swap_cgroup_ctrl[MAX_SWAPFILES];

Seems reasonable

Acked-by: Balbir Singh <bsingharora@...il.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/