linux-kernel - Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1109232354360.22872@utopia.booyaka.com>
Date:	Sat, 24 Sep 2011 00:20:30 -0600 (MDT)
From:	Paul Walmsley <paul@...an.com>
To:	"Munegowda, Keshava" <keshava_mgowda@...com>
cc:	"Cousson, Benoit" <b-cousson@...com>,
	"parthab@...ia.ti.com" <parthab@...ia.ti.com>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Balbi, Felipe" <balbi@...com>, "Gadiyar, Anand" <gadiyar@...com>,
	"sameo@...ux.intel.com" <sameo@...ux.intel.com>,
	"tony@...mide.com" <tony@...mide.com>,
	"Hilman, Kevin" <khilman@...com>,
	"johnstul@...ibm.com" <johnstul@...ibm.com>,
	"Sripathy, Vishwanath" <vishwanath.bs@...com>
Subject: Re: [PATCH 1/5 v11] arm: omap: usb: ehci and ohci hwmod structures
 for omap4

Hi

On Fri, 23 Sep 2011, Munegowda, Keshava wrote:

> Paul Walmsley <paul@...an.com> wrote:
>
> > So I'd suggest one of two approaches:
> >
> > 1. If the pin muxing can follow the PM runtime status of the UHH IP block,
> >   then the pin mux data should be associated with the UHH hwmod.
> 
> No, the mux is applicable only to ehci and ohci , where as sysconfig is 
> applicable to uhh ( usb_host_hs class).

My point is that, as far as I can tell, I/O pad wakeup (caused by USB 
remote wakeup) is only going to matter when the entire UHH IP block has 
its clocks cut.  Otherwise, while the UHH is clocked, the EHCI and/or OHCI 
IP blocks will also be clocked, so no I/O pad wakeup will be needed. Do 
you agree?

> > 2. If the pin muxing must follow the EHCI/OHCI IP block PM runtime status,
> >   then drivers/mfd/omap-usb-host.c is what should be handling the
> >   remuxing.  omap-usb-host.c can set the dev_pm_ops of the EHCI/OHCI
> >   platform_devices to point to functions either in
> >   arch/arm/mach-omap2/usb-host.c, or local functions that call into
> >   mach-omap2/usb-host.c functions to handle pin remuxing.  (Those
> >   function pointers should be provided to the MFD driver in some clean way,
> >   like via platform_data.)
> 
> The dev_pm_ops of ehci should exist in /drivers/usb/host/ehci-omap.c and 
> dev_pm_ops of phci should exist in /drivers/usb/host/ohci-omap3.c. In 
> the existing design, the omap-usb-host.c host can not access the 
> platform driver of ehci and ohci. But, through function pointers it is 
> possible to send the platform data to ehci and ohci drivers to handle 
> pin remuxing; but we will not able to use tero's patches; and it will 
> prevent our future design activity for remote wakeup of ehci and ohci.

Could you please explain in more detail why the dynamic remuxing can't 
be done when the UHH enters or exits idle?


- Paul