linux-kernel - Re: [rtc-linux] Re: [PATCH 2.6.39-rc7] RTC: rtc-ds1307 EEPROM support for ds1388 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110924065332.GA19721@pengutronix.de>
Date:	Sat, 24 Sep 2011 08:53:32 +0200
From:	Wolfram Sang <w.sang@...gutronix.de>
To:	rtc-linux@...glegroups.com
Cc:	Austin Boyle <Austin.Boyle@...atnet.com>,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Joakim Tjernlund <Joakim.Tjernlund@...nsmode.se>,
	linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [rtc-linux] Re: [PATCH 2.6.39-rc7] RTC: rtc-ds1307 EEPROM
 support for ds1388 chip

On Fri, Sep 23, 2011 at 04:04:45PM -0700, Andrew Morton wrote:
> On Mon, 1 Aug 2011 10:30:57 +1200
> Austin Boyle <Austin.Boyle@...atnet.com> wrote:
> 
> > [PATCH 3.0] RTC: EEPROM support for DS1388
> > 
> > This patch adds support for different sized NVRAM, such as
> > the 512 bytes of EEPROM on the DS1388 chip.
> 
> This patch is causing problems in today's linux-next, with x86_64 allmodconfig:

Sorry, I missed the patch so far. The whole approach is not correct.

The EEPROM uses a different I2C slave address (0x69+0x6a) than the RTC (0x68).
So, you should be able to use the ds1307-driver on address 0x68 (maybe with
minor modifications, didn't check that) and the eeprom part using the
at24-driver on address 0x69, selecting the 24c02-type. Despite saving redundant
code, at24 handles peculiarities of EEPROMs much better. Can you please report
if that works for you?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Download attachment "signature.asc" of type "application/pgp-signature" (199 bytes)