linux-kernel - Re: [PATCH v1] sched: fix nohz idle load balancer issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110926120105.GA8593@linux.vnet.ibm.com>
Date:	Mon, 26 Sep 2011 17:31:05 +0530
From:	Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Turner <pjt@...gle.com>,
	Venki Pallipadi <venki@...gle.com>,
	Ingo Molnar <mingo@...e.hu>,
	Vaidyanathan Srinivasan <svaidy@...ux.vnet.ibm.com>,
	Kamalesh Babulal <kamalesh@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] sched: fix nohz idle load balancer issues

* Srivatsa Vaddagiri <vatsa@...ux.vnet.ibm.com> [2011-09-26 17:20:49]:

> @@ -4695,8 +4719,11 @@ static inline int nohz_kick_needed(struc
>  	second_pick_cpu = atomic_read(&nohz.second_pick_cpu);
>  
>  	if (first_pick_cpu < nr_cpu_ids && first_pick_cpu != cpu &&
> -	    second_pick_cpu < nr_cpu_ids && second_pick_cpu != cpu)
> +	    second_pick_cpu < nr_cpu_ids && second_pick_cpu != cpu) {
> +		if (rq->nr_running > 1)
> +			return 1;
>  		return 0;
> +	}

I should have added a comment to explain this change ..will do it in
next version (along with any other changes suggested).

- vatsa

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/