linux-kernel - Re: [V6][PATCH 4/6] x86, nmi: add in logic to handle multiple events and unknown NMIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110926125546.GD5795@redhat.com>
Date:	Mon, 26 Sep 2011 08:55:46 -0400
From:	Don Zickus <dzickus@...hat.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	x86@...nel.org, Andi Kleen <andi@...stfloor.org>,
	Robert Richter <robert.richter@....com>, ying.huang@...el.com,
	LKML <linux-kernel@...r.kernel.org>, paulmck@...ux.vnet.ibm.com,
	avi@...hat.com, jeremy@...p.org
Subject: Re: [V6][PATCH 4/6] x86, nmi:  add in logic to handle multiple
 events and unknown NMIs

On Mon, Sep 26, 2011 at 10:59:14AM +0200, Peter Zijlstra wrote:
> On Fri, 2011-09-23 at 15:17 -0400, Don Zickus wrote:
> > +       /*
> > +        * Use 'false' as back-to-back NMIs are dealt with one level up.
> > +        * Of course this makes having multiple 'unknown' handlers useless
> > +        * as only the first one is ever run (unless it can actually determine
> > +        * if it caused the NMI)
> > +        */
> > +       handled = nmi_handle(NMI_UNKNOWN, regs, false); 
> 
> Shouldn't we then also add something like:
> 
> WARN_ON_ONCE(type == NMI_UNKNOWN && !list_empty(&desc->head));

That would make sense.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/