linux-kernel - Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 26 Sep 2011 08:45:54 -0600 (MDT)
From:	Paul Walmsley <paul@...an.com>
To:	"Munegowda, Keshava" <keshava_mgowda@...com>
cc:	parthab@...ia.ti.com, linux-usb@...r.kernel.org,
	linux-omap@...r.kernel.org, linux-kernel@...r.kernel.org,
	b-cousson@...com, balbi@...com, gadiyar@...com,
	sameo@...ux.intel.com, tony@...mide.com, khilman@...com,
	johnstul@...ibm.com, vishwanath.bs@...com
Subject: Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures
 for omap3

On Mon, 26 Sep 2011, Munegowda, Keshava wrote:

> On Sat, Sep 24, 2011 at 12:45 PM, Paul Walmsley <paul@...an.com> wrote:
> > On Fri, 23 Sep 2011, Munegowda, Keshava wrote:
> >
> >> On Thu, Sep 22, 2011 at 11:31 PM, Paul Walmsley <paul@...an.com> wrote:
> >> >
> >> > On Thu, 22 Sep 2011, Keshava Munegowda wrote:
> >> >> 4. usb_tll_hs hwmod of usbhs with the TLL base address and irq.
> >> >>
> >> >> Signed-off-by: Keshava Munegowda <keshava_mgowda@...com>
> >> >> Reviewed-by: Partha Basak <parthab@...ia.ti.com>
> >> >> ---
> >> >>  arch/arm/mach-omap2/omap_hwmod_3xxx_data.c |  271 ++++++++++++++++++++++++++++
> >> >>  1 files changed, 271 insertions(+), 0 deletions(-)
> >> >>
> >> >> diff --git a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> >> >> index 59fdb9f..d79f728 100644
> >> >> --- a/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> >> >> +++ b/arch/arm/mach-omap2/omap_hwmod_3xxx_data.c
> >
> >> >> +static struct omap_hwmod_ocp_if omap34xx_f128m_cfg__usb_host_hs = {
> >> >> +     .clk            = "usbhost_120m_fck",
> >> >
> >> > This doesn't look right.  This is an interface structure record, so it
> >> > should be associated with an interface clock.  Is the hardware really
> >> > using the functional clock as the interface clock?  Or, as seems more
> >> > likely...
> >>
> >>
> >> Agreed, how about:
> >>
> >> main clock: usbhost_120m_fck
> >> optional f clock: usbhost_48m_fck
> >
> > Assuming the interface clock is enabled, which one of these clocks is
> > needed for UHH register accesses to complete successfully?
> 
> it is usbhost_48m_fck ;
> so,
> main clock: usbhost_48m_fck
> optional clock : usbhost_120m_fck
> 
> do you agree?

Yes.


- Paul