linux-kernel - Re: [PATCHv2 1/2] perf tools: Collect tracing event data files directly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110926145836.GB8886@jolsa.brq.redhat.com>
Date:	Mon, 26 Sep 2011 16:58:36 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	David Ahern <dsahern@...il.com>
Cc:	acme@...hat.com, eric.dumazet@...il.com, fweisbec@...il.com,
	a.p.zijlstra@...llo.nl, mingo@...e.hu, paulus@...ba.org,
	linux-kernel@...r.kernel.org, rostedt@...dmis.org,
	nhorman@...driver.com
Subject: Re: [PATCHv2 1/2] perf tools: Collect tracing event data files
 directly

On Mon, Sep 26, 2011 at 07:43:02AM -0600, David Ahern wrote:
> 
> 

SNIP

> > +	/*
> > +	 * The '+ 5' is for '/' we add to the patch, plus NULL byte,
> > +	 * and one safety byte ;)
> > +	 */
> > +	file = malloc_or_die(strlen(path) + strlen(sys) +
> > +			     strlen(name) + strlen("format") + 5);
> 
> Why not go the simple route and just use PATH_MAX?
> 
> David

ok, seems more simple.. ;)

thanks,
jirka
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/