linux-kernel - Re: [PATCH 2/3][RT] sched: Do not compare cpu masks in scheduler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1317050811.26514.7.camel@gandalf.stny.rr.com>
Date:	Mon, 26 Sep 2011 11:26:50 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	linux-kernel@...r.kernel.org
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	Clark Williams <williams@...hat.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [PATCH 2/3][RT] sched: Do not compare cpu masks in scheduler

On Mon, 2011-09-26 at 11:08 -0400, Steven Rostedt wrote:

Grumble. Quilt seemed to have ignored the From: Peter ... part. 

The last two patches are Peter's not mine. I took his changes from a
patch he gave me on top of my patch.

-- Steve

> plain text document attachment
> (peterz-migrate-disable-no-cpu-compare.patch)
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> 
> Index: linux-rt.git/kernel/sched.c
> ===================================================================
> --- linux-rt.git.orig/kernel/sched.c
> +++ linux-rt.git/kernel/sched.c
> @@ -4235,16 +4235,12 @@ static inline void update_migrate_disabl
>  	 */
>  	mask = tsk_cpus_allowed(p);
>  
> -	WARN_ON(!cpumask_test_cpu(smp_processor_id(), mask));
> +	if (p->sched_class->set_cpus_allowed)
> +		p->sched_class->set_cpus_allowed(p, mask);
> +	p->rt.nr_cpus_allowed = cpumask_weight(mask);
>  
> -	if (!cpumask_equal(&p->cpus_allowed, mask)) {
> -		if (p->sched_class->set_cpus_allowed)
> -			p->sched_class->set_cpus_allowed(p, mask);
> -		p->rt.nr_cpus_allowed = cpumask_weight(mask);
> -
> -		/* Let migrate_enable know to fix things back up */
> -		p->migrate_disable |= MIGRATE_DISABLE_SET_AFFIN;
> -	}
> +	/* Let migrate_enable know to fix things back up */
> +	p->migrate_disable |= MIGRATE_DISABLE_SET_AFFIN;
>  }
>  
>  void migrate_disable(void)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/