linux-kernel - Re: [PATCH] xen: Fix selfballooning and ensure it doesn't go too far

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110926172307.GA9973@phenom.oracle.com>
Date:	Mon, 26 Sep 2011 13:23:07 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Dan Magenheimer <dan.magenheimer@...cle.com>
Cc:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	David Vrabel <david.vrabel@...rix.com>,
	Jeremy Fitzhardinge <jeremy@...p.org>
Subject: Re: [PATCH] xen: Fix selfballooning and ensure it doesn't go too far

On Sat, Sep 24, 2011 at 01:58:08PM -0700, Dan Magenheimer wrote:
> [PATCH] xen: Fix selfballooning and ensure it doesn't go too far
> 
> The balloon driver's "current_pages" is very different from
> totalram_pages.  Self-ballooning needs to be driven by
> the latter.  Also, Committed_AS doesn't account for pages
> used by the kernel so enforce a floor for when there
> are little or no user-space threads using memory.

Hey Dan,
..
> +		floor_pages = totalreserve_pages +
> +				(roundup_pow_of_two(max_pfn) >> 5);

Would it make sense to make the shift be a runtime argument
in case some users report problems with that calculation?

> +		/* don't balloon too far, lest OOMs occur... */
> +		if (tgt_pages < floor_pages)
> +			tgt_pages = floor_pages;
> +		balloon_set_new_target(tgt_pages +
> +			balloon_stats.current_pages - totalram_pages);
>  		reset_timer = true;
>  	}
>  #ifdef CONFIG_FRONTSWAP

Otherwise it looks OK to me. Would you like me to queue it up
for 3.1-rc7?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/