[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110926221511.GB19769@suse.de>
Date: Mon, 26 Sep 2011 15:15:11 -0700
From: Greg KH <gregkh@...e.de>
To: Oleg Nesterov <oleg@...hat.com>
Cc: Tejun Heo <htejun@...il.com>, Luke Macken <lmacken@...hat.com>,
stable@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH stable-3.0] ptrace: don't clear GROUP_STOP_SIGMASK on
double-stop
On Mon, Sep 26, 2011 at 07:06:32PM +0200, Oleg Nesterov wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=740121
>
> 1. Luke Macken triggered WARN_ON(!(group_stop & GROUP_STOP_SIGMASK))
> in do_signal_stop().
>
> This is because do_signal_stop() clears GROUP_STOP_SIGMASK part
> unconditionally but doesn't update it if task_is_stopped().
>
> 2. Looking at this problem I noticed that WARN_ON_ONCE(!ptrace) is
> not right, a stopped-but-resumed tracee can clone the untraced
> thread in the SIGNAL_STOP_STOPPED group, the new thread can start
> another group-stop.
>
> Remove this warning, we need more fixes to make it true.
>
> Reported-by: Luke Macken <lmacken@...hat.com>
> Signed-off-by: Oleg Nesterov <oleg@...hat.com>
Is this fix in Linus's tree already? If so, what's the git commit id?
If not, please take a look at Documentation/stable_kernel_rules.txt for
how to properly submit a patch to the stable tree.
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists