linux-kernel - Re: [PATCH] usb/core/devio.c: Check for printer class specific request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110926223430.GA21960@kroah.com>
Date:	Mon, 26 Sep 2011 15:34:30 -0700
From:	Greg KH <greg@...ah.com>
To:	Matthias Dellweg <2500@....de>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb/core/devio.c: Check for printer class specific
 request

On Sun, Sep 25, 2011 at 02:46:51PM +0200, Matthias Dellweg wrote:
> From: Matthias Dellweg <2500@....de>
> 
> In the usb printer class specific request get_device_id the value of
> wIndex is (interface << 8 | altsetting) instead of just interface.
> This enables the detection of some printers with libusb.
> 
> The hardware I tested this patch with is a Prolific
> USB->Centronics cable (067b:2305).
> 
> Acked-by: Alan Stern <stern@...land.harvard.edu>
> Signed-off-by: Matthias Dellweg <2500@....de>
> Cc: stable <stable@...nel.org>
> ---
>  drivers/usb/core/devio.c |   21 ++++++++++++++++++---
>  1 files changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/core/devio.c b/drivers/usb/core/devio.c
> index 37518df..1d73709 100644
> --- a/drivers/usb/core/devio.c
> +++ b/drivers/usb/core/devio.c
> @@ -607,9 +607,10 @@ static int findintfep(struct usb_device *dev, unsigned int ep)
>  }
>  
>  static int check_ctrlrecip(struct dev_state *ps, unsigned int requesttype,
> -                          unsigned int index)
> +                          unsigned int request, unsigned int index)
>  {
>         int ret = 0;
> +       struct usb_host_interface *alt_setting;
>  
>         if (ps->dev->state != USB_STATE_UNAUTHENTICATED
>          && ps->dev->state != USB_STATE_ADDRESS

All of the tabs were stripped out of this email, making it impossible to
apply it :(

Care to fix this up and resend it so that I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/