linux-kernel - Re: [PATCH 2/2] user namespace: usb: make usb urbs user namespace aware (v2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110926234540.GA28525@kroah.com>
Date:	Mon, 26 Sep 2011 16:45:40 -0700
From:	Greg KH <greg@...ah.com>
To:	Serge Hallyn <serge.hallyn@...onical.com>
Cc:	Alan Stern <stern@...land.harvard.edu>,
	"Serge E. Hallyn" <serge@...lyn.com>,
	Oleg Nesterov <oleg@...hat.com>,
	lkml <linux-kernel@...r.kernel.org>, richard@....at,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Tejun Heo <tj@...nel.org>, linux-usb@...r.kernel.org
Subject: Re: [PATCH 2/2] user namespace: usb: make usb urbs user namespace
 aware (v2)

On Mon, Sep 26, 2011 at 10:45:18AM -0500, Serge Hallyn wrote:
> Add to the dev_state and alloc_async structures the user namespace
> corresponding to the uid and euid.  Pass these to kill_pid_info_as_uid(),
> which can then implement a proper, user-namespace-aware uid check.
> 
> Changelog:
> Sep 20: Per Oleg's suggestion: Instead of caching and passing user namespace,
> 	uid, and euid each separately, pass a struct cred.
> Sep 26: Address Alan Stern's comments: don't define a struct cred at
> 	usbdev_open(), and take and put a cred at async_completed() to
> 	ensure it lasts for the duration of kill_pid_info_as_cred().
> 
> Signed-off-by: Serge Hallyn <serge.hallyn@...onical.com>
> Cc: Greg KH <greg@...ah.com>

I have no objection to this, is it going to go through your tree, or
somewhere else?

If so, please add:
	Acked-by: Greg Kroah-Hartman <gregkh@...e.de>
to it.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/