linux-kernel - Re: [PATCH] gfs2/inode.c: local functions should be static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1317025658.2744.0.camel@menhir>
Date:	Mon, 26 Sep 2011 09:27:38 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	H Hartley Sweeten <hartleys@...ionengravers.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	cluster-devel@...hat.com
Subject: Re: [PATCH] gfs2/inode.c: local functions should be static

Hi,

On Fri, 2011-09-23 at 15:51 -0700, H Hartley Sweeten wrote:
> Quiets the sparse noise:
> 
> warning: symbol 'gfs2_initxattrs' was not declared. Should it be static?
> 
Where did you find this function? It is not in the upstream gfs2 code...

Steve.

> Signed-off-by: H Hartley Sweeten <hsweeten@...ionengravers.com>
> Cc: Steven Whitehouse <swhiteho@...hat.com>
> 
> ---
> 
> diff --git a/fs/gfs2/inode.c b/fs/gfs2/inode.c
> index 5431de9..5f2b157 100644
> --- a/fs/gfs2/inode.c
> +++ b/fs/gfs2/inode.c
> @@ -624,7 +624,7 @@ fail:
>  	return error;
>  }
>  
> -int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
> +static int gfs2_initxattrs(struct inode *inode, const struct xattr *xattr_array,
>  		    void *fs_info)
>  {
>  	const struct xattr *xattr;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/