| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 27 Sep 2011 10:21:59 +0800 From: Axel Lin <axel.lin@...il.com> To: Tabi Timur-B04825 <B04825@...escale.com> Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Liam Girdwood <lrg@...com>, Mark Brown <broonie@...nsource.wolfsonmicro.com>, "alsa-devel@...a-project.org" <alsa-devel@...a-project.org> Subject: Re: [PATCH] ASoC: fsl: Fix error handling if platform_device_add fails 2011/9/27 Tabi Timur-B04825 <B04825@...escale.com>: > Axel Lin wrote: >> Call platform_device_put() instead of platform_device_unregister() if >> platform_device_add() fails. > > What's wrong with calling platform_device_unregister()? /** * platform_device_unregister - unregister a platform-level device * @pdev: platform device we're unregistering * * Unregistration is done in 2 steps. First we release all resources * and remove it from the subsystem, then we drop reference count by * calling platform_device_put(). */ platform_device_unregister() actually calls platform_device_del() and platform_device_put(). If platform_device_add() call fails, we failed to add the platform device to device hierarchy. Thus we can just call platform_device_put() instead. > > -- > Timur Tabi > Linux kernel developer at Freescale > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists