linux-kernel - Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures for omap3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20110927205230.GE2254@legolas.emea.dhcp.ti.com>
Date:	Tue, 27 Sep 2011 23:52:33 +0300
From:	Felipe Balbi <balbi@...com>
To:	Tero Kristo <t-kristo@...com>
Cc:	"Balbi, Felipe" <balbi@...com>,
	"Munegowda, Keshava" <keshava_mgowda@...com>,
	Paul Walmsley <paul@...an.com>,
	"Cousson, Benoit" <b-cousson@...com>,
	"Basak, Partha" <p-basak2@...com>, parthab@...ia.ti.com,
	linux-usb@...r.kernel.org, linux-omap@...r.kernel.org,
	linux-kernel@...r.kernel.org, "Gadiyar, Anand" <gadiyar@...com>,
	sameo@...ux.intel.com, tony@...mide.com,
	"Hilman, Kevin" <khilman@...com>, johnstul@...ibm.com,
	"Sripathy, Vishwanath" <vishwanath.bs@...com>
Subject: Re: [PATCH 2/5 v11] arm: omap: usb: ehci and ohci hwmod structures
 for omap3

hi,

On Tue, Sep 27, 2011 at 05:38:51PM +0300, Tero Kristo wrote:
> > On Tue, Sep 27, 2011 at 06:48:35PM +0530, Munegowda, Keshava wrote:
> > > > So, you would need a mechanism to do something like this:
> > > >
> > > > pad a or b wakeup detected -> irq0
> > > > pad c or d wakeup detected -> irq1?
> > > 
> > > yes, if get something like this , its perfect.
> > 
> > can't you have different IRQs for each pad ? I mean, allocate one
> > irq_desc for each pad and let drivers request a pad/pin as an IRQ
> > source. Then, when you detect a pad wakeup, you can:
> 
> Direct pad to irq mapping was turned down on some previous version of
> the prcm chain handler set, but yes, it is a potential approach. However

do you remember what was the reason for that being turned down ? Maybe I
can search the archives...

> the irq_desc allocation mechanism should be dynamic... there are some
> 200 programmable pads anyway.

I wouldn't worry too much about that. If you try to allocate irq_desc
dynamically, you would have to keep track of an "irq_base" for each
irq_desc you allocate, otherwise it's difficult to map it back to mux
number.

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (491 bytes)