linux-kernel - Re: [GIT PULL] block fixes for 3.1-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFxWHBEBaWfWcdOHucAiMHnTH+y1WRq6gik+=NGA1FNh=Q@mail.gmail.com>
Date:	Tue, 27 Sep 2011 16:52:48 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <axboe@...nel.dk>,
	James Bottomley <jbottomley@...allels.com>,
	Alan Stern <stern@...land.harvard.edu>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] block fixes for 3.1-rc

On Wed, Sep 21, 2011 at 5:19 AM, Jens Axboe <axboe@...nel.dk> wrote:
>
> Final round of patches for 3.1.

Apparently better not.

The "block layer oopses on USB device removal" is still there, it seems.

I can even find a patch from it from Alan Stern:

   https://lkml.org/lkml/2011/9/18/63

and the reason I found that was that my wife's machine just saw what
looks very much like that bug in elv_put_request().

The call chain on that particular machine was:

 - __blk_put_request
  blk_put_request
  scsi_execute
  scsi_execute_req
  sd_check_events
  disk_events_workfn
  process_one_work

in one of the kthread helpers. It sounds like something either
generates disk events after the unplug event (despite a "safely
remove" thing), or doesn't properly wait for the disk events to have
flushed before the elevator is cleared.

The "things go oops at USB removal" reports have been with us for a
*loong* time now. Can we please get this fixed already, and have
somebody really look at it?

And if you can't figure out why it happens, at least apply Alan's
patch (or ack it).

                  Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/