linux-kernel - Re: [patch 1/2]block: avoid unnecessary plug list flush

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87y5x9cau0.fsf@gmail.com>
Date:	Wed, 28 Sep 2011 17:47:35 +0900
From:	Namhyung Kim <namhyung@...il.com>
To:	Shaohua Li <shaohua.li@...el.com>
Cc:	Jens Axboe <axboe@...nel.dk>, lkml <linux-kernel@...r.kernel.org>
Subject: Re: [patch 1/2]block: avoid unnecessary plug list flush

Shaohua Li <shaohua.li@...el.com> writes:

> get_request_wait() could sleep and flush the plug list. If the list
> is already flushed, don't flush again.
>
> Signed-off-by: Shaohua Li <shaohua.li@...el.com>
Reviewed-by: Namhyung Kim <namhyung@...il.com>

Good catch! If get_request_wait() updated request_count after sleeping
we could live with the original code, but your change makes more sense IMHO.

Thanks.


>
> ---
>  block/blk-core.c |   16 +++++++++-------
>  1 file changed, 9 insertions(+), 7 deletions(-)
>
> Index: linux/block/blk-core.c
> ===================================================================
> --- linux.orig/block/blk-core.c	2011-09-28 11:05:06.000000000 +0800
> +++ linux/block/blk-core.c	2011-09-28 11:05:22.000000000 +0800
> @@ -1299,15 +1299,17 @@ get_rq:
>  		 */
>  		if (list_empty(&plug->list))
>  			trace_block_plug(q);
> -		else if (!plug->should_sort) {
> -			struct request *__rq;
> +		else {
> +			if (!plug->should_sort) {
> +				struct request *__rq;
>  
> -			__rq = list_entry_rq(plug->list.prev);
> -			if (__rq->q != q)
> -				plug->should_sort = 1;
> +				__rq = list_entry_rq(plug->list.prev);
> +				if (__rq->q != q)
> +					plug->should_sort = 1;
> +			}
> +			if (request_count >= BLK_MAX_REQUEST_COUNT)
> +				blk_flush_plug_list(plug, false);
>  		}
> -		if (request_count >= BLK_MAX_REQUEST_COUNT)
> -			blk_flush_plug_list(plug, false);
>  		list_add_tail(&req->queuelist, &plug->list);
>  		drive_stat_acct(req, 1);
>  	} else {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/