[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20110928125249.GH3279@opensource.wolfsonmicro.com>
Date: Wed, 28 Sep 2011 13:52:50 +0100
From: Mark Brown <broonie@...nsource.wolfsonmicro.com>
To: Dimitris Papastamos <dp@...nsource.wolfsonmicro.com>
Cc: linux-kernel@...r.kernel.org, Lars-Peter Clausen <lars@...afoo.de>
Subject: Re: [PATCH 3/7] regmap: Add a mutex to guard the sync operation
On Wed, Sep 28, 2011 at 11:43:43AM +0100, Dimitris Papastamos wrote:
> + mutex_lock(&map->sync_lock);
> dev_dbg(map->dev, "Syncing %s cache\n",
> map->cache_ops->name);
> name = map->cache_ops->name;
> @@ -254,6 +257,7 @@ int regcache_sync(struct regmap *map)
> }
> out:
> trace_regcache_sync(map->dev, name, "stop");
> + mutex_unlock(&map->sync_lock);
Shouldn't we either be taking the regmap lock when doing the sync or
otherwise guarding against something other than a cache sync?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists