linux-kernel - Re: [PATCH v5]: Improve performance of LZO hibernation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 28 Sep 2011 23:18:55 +1000
From:	"Bojan Smojver" <bojan@...ursive.com>
To:	penberg@...helsinki.fi
Cc:	linux-kernel@...r.kernel.org, rjw@...k.pl
Subject: Re: [PATCH v5]: Improve performance of LZO hibernation

------- Original message -------
> From: Pekka Enberg

> On Wed, Sep 28, 2011 at 10:54 AM, Bojan Smojver <bojan@...ursive.com> 
> wrote:
>> I'm guessing here that you mean that parts of the kernel other than
>> hibernation code itself can do this (i.e. set the flag for the thread to
>> stop, so kthread_should_stop() returns true). Correct?
>
> Sorry, I'm not familiar this code. However, if you're checking for the
> condition..
>
> [snip]
>
>> Right now, this would result in - well I don't know what exactly - most
>> likely corrupted data on disk or on memory.
>
> ...this is not really an option for handling it.

Yeah, I changed the code in v7 to set the error code when this happens. So, 
if the thread exits because something sets should_exit flag, error code 
will terminate hibernation/thaw.

Now that I think about it, another problem may come up if the thread has 
been shut down by something else just as it's supposed to be cleaned up at 
end of the run. I can introduce a mutex in each structure and then 
set/check whether thread pointer is NULL before reping the thread.

V8, here we come...

--
Bojan 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/